netdev - Re: Fix FRTO+NewReno problem (Was: Re: This has a work around)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482849C9.30905@damtek.com>
Date:	Mon, 12 May 2008 09:44:41 -0400
From:	"Damon L. Chesser" <damon@...tek.com>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
CC:	Netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: Fix FRTO+NewReno problem (Was: Re: This has a work around)

Ilpo Järvinen wrote:
> On Mon, 12 May 2008, Damon L. Chesser wrote:
>
>   
>> I ran the first patch and received this error:
>>
>> root@...-main:/usr/src/linux-2.6.24.1# patch -p1 < ../1st_frto_patch.diff
>> patching file net/ipv4/tcp_input.c
>> patch: **** malformed patch at line 17: @@ -1685,6 +1683,10 @@ static inline
>> void tcp_reset_reno_sack(struct tcp_sock *tp)
>>
>> root@...-main:/usr/src/linux-2.6.24.1#
>>
>> below is the text of the patch.diff I have:
>>     
>
> I suppose there was some space-vs-tab or additional-line-break added 
> issue while you saved it. Please try to save from the attached files 
> instead, it should keep the original formatting, they work as is with 
> patch -p1 (no need to cut anything). I tried them into 2.6.24.1 and both 
> of those should apply, though with some fuzz.
>
> --
>  i.
Ilpo,

I applied the patches in order, no errors on that.  I compiled a stock 
2.4.24-1 kernel with the patches, I saw no errors there.

booted into new kernel, printed with tcp_frto=0.  set tcp_frto =2, 
restarted the network (is this required, or is this a dynamic setting?), 
printed from OO document.  No joy.  tcpdump log attached (almost 15 min. 
worth of data)

If you want, I can re-compile and double check for any compilation 
errors, however, if there were any, it was not sever enough to stop the 
compilation.

-- 
Damon L. Chesser
damon@...tek.com
http://www.linkedin.com/in/dchesser

View attachment "frtoprob4.txt" of type "text/plain" (35006 bytes)