netdev - Re: [PATCH 3/6] drivers/net: remove null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080512161734.GA22190@electric-eye.fr.zoreil.com>
Date:	Mon, 12 May 2008 18:17:34 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference

Julia Lawall <julia@...u.dk> :
[...]
> diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> --- a/drivers/net/au1000_eth.c	2008-04-27 11:41:11.000000000 +0200
> +++ b/drivers/net/au1000_eth.c	2008-05-12 09:32:54.000000000 +0200
> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int 
>  	struct net_device *dev = (struct net_device *) dev_id;
>  
>  	if (dev == NULL) {
> -		printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
> +		printk(KERN_ERR "isr: null dev ptr\n");
>  		return IRQ_RETVAL(1);
>  	}

The lifespan of 'dev' covers the request_irq..free_irq interval in this
driver. The whole 'dev == NULL' block can be removed.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html