[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OFEAF0762D.B7C9C8DD-ON88257447.005CE64E-88257447.005D6A63@us.ibm.com>
Date: Mon, 12 May 2008 10:00:21 -0700
From: David Stevens <dlstevens@...ibm.com>
To: YOSHIFUJI Hideaki / 吉藤英明
<yoshfuji@...ux-ipv6.org>
Cc: davem@...emloft.net, Joseph.Bonitch@...ox.com,
netdev@...r.kernel.org, netdev-owner@...r.kernel.org,
yoshfuji@...ux-ipv6.org
Subject: Re: IPV6 stateless address autoconfiguration
> + } else if (~rt_expires) {
> + /* not infinity */
> + rt->rt6i_expires = jiffies + rt_expires;
> + rt->rt6i_flags |= RTF_EXPIRES;
rt_expires is "unsigned long" -- won't the high-order
bits be set on 64-bit machines?
Also, don't you need to check before the divide by
USER_HZ?
+-DLS
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists