netdev - Re: mac80211 truesize bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1210712356.4279.22.camel@johannes.berg>
Date:	Tue, 13 May 2008 22:59:16 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"John W. Linville" <linville@...driver.com>
Cc:	David Miller <davem@...emloft.net>, herbert@...dor.apana.org.au,
	mb@...sch.de, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: mac80211 truesize bugs

On Tue, 2008-05-13 at 16:39 -0400, John W. Linville wrote:
> On Mon, May 12, 2008 at 08:17:51PM -0700, David Miller wrote:
> 
> > Based upon them I will adjust LL_MAX_HEADER as follows:
> 
> > @@ -93,14 +93,16 @@ struct wireless_dev;
> >   *	used.
> >   */
> >   
> > -#if !defined(CONFIG_AX25) && !defined(CONFIG_AX25_MODULE) && !defined(CONFIG_TR)
> > -#define LL_MAX_HEADER	32
> > +#if defined(CONFIG_WLAN_80211) || defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE)
> 
> Is WLAN_80211 really the right symbol here?  It applies to more than
> just mac80211, and I doubt if full MAC devices need higher values.
> It seems like MAC80211 would be the right symbol to add.

Most fullmac devices also need some space, whether they do things that
way or not is a completely different thing, the ieee80211 stack for
example copies every packet into a new skb anyway.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)