netdev - Re: [PATCH 18/18] flag parameters: check magic constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080512.213925.193699728.davem@davemloft.net>
Date:	Mon, 12 May 2008 21:39:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	drepper@...hat.com
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, davidel@...ilserver.org,
	mtk.manpages@...il.com, torvalds@...ux-foundation.org
Subject: Re: [PATCH 18/18] flag parameters: check magic constants

From: Ulrich Drepper <drepper@...hat.com>
Date: Mon, 12 May 2008 21:21:29 -0700

> Is MIPS really a problem?  The value is 0x80.  128 protocol types should
> be enough.  Even if not, there is no reason why the numbers should be
> consecutive.  It's easy enough to skip over a bit.  I.e., after procotol
> 0x7f the next one would be 0x100.

Indeed, MIPS looks good.

> And PA seems to have gotten O_NONBLOCK wrong.  SPARC does it right AFAICS.

I agree.

But that value is compiled into every parisc binary out there,
limiting what we can do about it in the short term.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html