netdev - Re: [PATCH 1/9] Add TSO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 May 2008 01:17:46 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 1/9] Add TSO support

Ben Hutchings wrote:
> The SFC4000 controller does not have hardware support for TSO, and the
> core GSO code incurs a high cost in allocating and freeing skbs.  This
> TSO implementation uses lightweight packet header structures and is
> substantially faster.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
>  drivers/net/sfc/efx.c        |    4 +-
>  drivers/net/sfc/ethtool.c    |   27 ++
>  drivers/net/sfc/net_driver.h |   14 +
>  drivers/net/sfc/tx.c         |  664 ++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 708 insertions(+), 1 deletions(-)

applied 1-9, with two comments:

1) your subject line is missing a useful prefix.  see
http://linux.yyz.us/patch-format.html

2) normally TSO addition would not be permitting during the 
bug-fixes-only phase of the kernel development (2.6.26-rc is current), 
but since the driver is new, it is reasonable because there can be no 
regressions

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html