netdev - SFC driver implements its own I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080513103325.1ab317cf@hyperion.delvare>
Date:	Tue, 13 May 2008 10:33:25 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	Jeff Garzik <jgarzik@...hat.com>
Cc:	netdev@...r.kernel.org, Linux I2C <i2c@...sensors.org>
Subject: SFC driver implements its own I2C support

Hi Ben, hi Jeff,

My attention was brought to the drivers/net/sfc/i2c-direct.c file which
appeared recently in the Linux kernel. Apparently this is a custom
implementation of I2C support, including software bit-banging. All this
is already available in the Linux kernel in:
  drivers/i2c/i2c-core.c
  drivers/i2c/algos/i2c-algo-bit.c
So it really doesn't make sense to duplicate the code in the sfc
network driver.

Can you please get rid of this custom I2C implementation and use the
standard one? It should be really easy, all you have to do is include
<linux/i2c.h> and <linux/i2c-algo-bit.h>, pack your SDA and SCL get/set
functions in a struct i2c_algo_bit_data, and call i2c_bit_add_bus() on
it. See drivers/video/intelfb/intelfb_i2c.c (or any framebuffer driver
with I2C/DDC support) for an example.

Using the standard I2C implementation will give you access to all the
i2c debugging tools, user-space access to the I2C bus if needed, and
compatibility with all the Linux i2c device drivers, including hardware
monitoring and GPIO drivers which apparently the SFC hardware uses.

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html