netdev - RE: [PATCH 2/2] s2io: add missing block braces to multistatement if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 May 2008 12:22:35 -0400
From:	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
	"Jeff Garzik" <jeff@...zik.org>
Cc:	<netdev@...r.kernel.org>,
	"Rastapur Santosh" <santosh.rastapur@...erion.com>,
	"Sivakumar Subramani" <Sivakumar.Subramani@...erion.com>,
	"Sreenivasa Honnur" <Sreenivasa.Honnur@...erion.com>
Subject: RE: [PATCH 2/2] s2io: add missing block braces to multistatement if statement

Jeff,

Patch looks good. Please accept.

Thanks,
Ram

> -----Original Message-----
> From: Ilpo Järvinen [mailto:ilpo.jarvinen@...sinki.fi]
> Sent: Tuesday, May 13, 2008 4:17 AM
> To: Jeff Garzik
> Cc: netdev@...r.kernel.org; Ilpo Jrvinen; Ramkrishna Vepa; Rastapur
> Santosh; Sivakumar Subramani; Sreenivasa Honnur
> Subject: [PATCH 2/2] s2io: add missing block braces to multistatement if
> statement
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> Cc: Ramkrishna Vepa <ram.vepa@...erion.com>
> Cc: Rastapur Santosh <santosh.rastapur@...erion.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@...erion.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@...erion.com>
> ---
>  drivers/net/s2io.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
> index 523478e..0f3d230 100644
> --- a/drivers/net/s2io.c
> +++ b/drivers/net/s2io.c
> @@ -1113,9 +1113,10 @@ static int s2io_on_nec_bridge(struct pci_dev
> *s2io_pdev)
>  	struct pci_dev *tdev = NULL;
>  	while ((tdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, tdev)) !=
> NULL) {
>  		if (tdev->vendor == NEC_VENID && tdev->device == NEC_DEVID) {
> -			if (tdev->bus == s2io_pdev->bus->parent)
> +			if (tdev->bus == s2io_pdev->bus->parent) {
>  				pci_dev_put(tdev);
>  				return 1;
> +			}
>  		}
>  	}
>  	return 0;
> --
> 1.5.2.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html