netdev - Re: [patch 4/8] hysdn: remove cli()/sti() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080514.164140.229890751.davem@davemloft.net>
Date:	Wed, 14 May 2008 16:41:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, mark.asselstine@...driver.com,
	kkeil@...e.de
Subject: Re: [patch 4/8] hysdn: remove cli()/sti() calls

From: akpm@...ux-foundation.org
Date: Wed, 14 May 2008 16:19:43 -0700

> From: Mark Asselstine <mark.asselstine@...driver.com>
> 
> The use of cli()/sti() within the do/while was a way to ensure interrupts were
> only disabled for short periods of time while the bulk of the time interrupts
> were free to occur.  The use of the spin lock has eliminated the need to play
> with interrupts in this way while still allowing for IO to be protected.
> 
> The remaining 3 sti() calls seem unneeded now that at no other point in the
> driver is there a call to cli().
> 
> Signed-off-by: Mark Asselstine <mark.asselstine@...driver.com>
> Acked-by: Karsten Keil <kkeil@...e.de>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html