netdev - Re: ip_finish_outpu2 question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 May 2008 14:17:58 +0530
From:	"kalash nainwal" <kalash.nainwal@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	bshanth@...il.com, netdev@...r.kernel.org
Subject: Re: ip_finish_outpu2 question

On Wed, May 14, 2008 at 10:04 AM, David Miller <davem@...emloft.net> wrote:
> From: Prashanth <bshanth@...il.com>
> Date: Wed, 14 May 2008 09:12:54 +0530
>
>> hi, In the following function at line 189 , we are getting aligned
>> length (hh_alen) for the hardware header , but while doing a
>> skb_push() why are we using the hh->hh_len;for ethernet hh_alen would
>> be 16 , and hh->hh_len would be 14, since we are doing skb_push() with
>> 14 (i.e hh->hh_len), the skb->data will not be aligned right? Can
>> someone please shed some light on this. thanks.
>
> We are using 16 for the copy so that we do an aligned
> copy.  But the ethernet header size is only 14 bytes.
>

I thought memcpy in linux is anyway always alignment safe. no?

-Kalash
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html