netdev - Re: dead network on JS21 with tg3 driver after flowcontrol changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 May 2008 12:51:18 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Matt Carlson" <mcarlson@...adcom.com>
cc:	"Olaf Hering" <olaf@...fle.de>, linuxppc-dev@...abs.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: dead network on JS21 with tg3 driver after flowcontrol
 changes

On Thu, 2008-05-15 at 10:15 -0700, Matt Carlson wrote:
> If you were to start with the original file, does the following patch
> fix the problem?
> 
> 
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 07b3f77..4c248d7 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -3168,8 +3168,7 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, int force_reset)
>  	err |= tg3_readphy(tp, MII_BMCR, &bmcr);
>  
>  	if ((tp->link_config.autoneg == AUTONEG_ENABLE) && !force_reset &&
> -	    (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT) &&
> -	     tp->link_config.flowctrl == tp->link_config.active_flowctrl) {
> +	    (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT)) {
>  		/* do nothing, just check for link up at the end */
>  	} else if (tp->link_config.autoneg == AUTONEG_ENABLE) {
>  		u32 adv, new_adv;
> 

Matt, I think that's very likely the problem.  If we are trying to
establish link in parallel detect mode, the flow control settings may
not match.  If we do not enter the if statement to do nothing, we will
keep autonegotiating forever and never establish link.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html