netdev - Re: [patch] resource leak in error case in rtl8187

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080515185724.GA17690@tuxdriver.com>
Date:	Thu, 15 May 2008 14:57:24 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, Michael Wu <flamingice@...rmilk.net>,
	Andrea Merello <andreamrl@...cali.it>
Subject: Re: [patch] resource leak in error case in rtl8187

On Thu, May 15, 2008 at 04:17:36PM +0200, Oliver Neukum wrote:
> Hi,
> 
> this fixes a resource leak in the error case of the write code path.
> 
> 	Regards
> 		Oliver
> 
> Signed-off-by: Oliver Neukum <oneukum@...e.de>
> 
> ---
> 
> --- linux-2.6.26-rc1/drivers/net/wireless/rtl8187_dev.c.alt	2008-05-15 15:53:58.000000000 +0200
> +++ linux-2.6.26-rc1/drivers/net/wireless/rtl8187_dev.c	2008-05-15 15:57:35.000000000 +0200
> @@ -169,6 +169,7 @@ static int rtl8187_tx(struct ieee80211_h
>  	struct urb *urb;
>  	__le16 rts_dur = 0;
>  	u32 flags;
> +	int rv;
>  
>  	urb = usb_alloc_urb(0, GFP_ATOMIC);
>  	if (!urb) {
> @@ -208,7 +209,11 @@ static int rtl8187_tx(struct ieee80211_h
>  	info->dev = dev;
>  	usb_fill_bulk_urb(urb, priv->udev, usb_sndbulkpipe(priv->udev, 2),
>  			  hdr, skb->len, rtl8187_tx_cb, skb);
> -	usb_submit_urb(urb, GFP_ATOMIC);
> +	rv = usb_submit_urb(urb, GFP_ATOMIC);
> +	if (rv < 0) {
> +		usb_free_urb(urb);
> +		kfree_skb(skb);
> +	}
>  
>  	return 0;
>  }

Don't we need the same type of fix applied to rtl8187_iowrite_async
as well?  Would you like to resubmit (or submit a second patch)
with that fix included?

Also, a nit: I would prefer "rc" instead of "rv" just for idiomatic
purposes.

John
-- 
John W. Linville
linville@...driver.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html