netdev - Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080515144313.524d199d@infradead.org>
Date:	Thu, 15 May 2008 14:43:13 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	"Christophe Jaillet" <christophe.jaillet@...adoo.fr>
Cc:	"cj" <christophe.jaillet@...adoo.fr>,
	"linux" <linux-kernel@...r.kernel.org>,
	<florian.fainelli@...ecomint.eu>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies()
 ???

On Thu, 15 May 2008 23:26:22 +0200
"Christophe Jaillet" <christophe.jaillet@...adoo.fr> wrote:

> From: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> 
> Hi, here is a patch against linux/drivers/net/r6040.c.
> 
> Compared to other places in the kernel, I think that this driver
> misuses the function round_jiffies.
> 
> 
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
> 
> Signed-off-by: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> 
> ---
> 
> --- linux 2.6.25/drivers/net/r6040.c	2008-05-15
> 23:21:28.000000000 +0200 +++ linux
> 2.6.25/drivers/net/r6040.c.cj	2008-05-15 22:16:44.000000000
> +0200 @@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da }
>  
>  	/* Timer active again */
> -	mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
> +	mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
>  }
>  

good catch!
Acked-by: Arjan van de Ven <arjan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html