netdev - RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <989B956029373F45A0B8AF0297081890022E142D@zch01exm26.fsl.freescale.net>
Date:	Thu, 15 May 2008 11:03:24 +0800
From:	"Li Yang" <LeoLi@...escale.com>
To:	<joakim.tjernlund@...nsmode.se>
Cc:	"Netdev" <netdev@...r.kernel.org>
Subject: RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@...nsmode.se] 
> Sent: Wednesday, May 14, 2008 6:50 PM
> To: Li Yang
> Cc: Netdev
> Subject: RE: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> 
> I didn't see them in my manual so I figured they were extra. 
> If you find them please let me know where.

I'm reading from MPC8360ERM Rev. 2.  They have the following definition:

UCCx_BASE+0x1C4  Frames discarded due to overrun condition in the
RxFIFO.
REBASE+5C Counts the total number of fames that have an IPChecsum Error.

Which manual are you using?

- Leo
> 
> On Wed, 2008-05-14 at 18:37 +0800, Li Yang wrote:
> > Hi Joakim,
> > 
> > I admit that I missed one in tx firmware stats.  But why are you 
> > deleting the other two?
> > 
> > - Leo
> > 
> > > -----Original Message-----
> > > From: Joakim Tjernlund [mailto:Joakim.Tjernlund@...nsmode.se]
> > > Sent: Tuesday, May 13, 2008 4:05 PM
> > > To: Netdev; Li Yang
> > > Cc: Joakim Tjernlund
> > > Subject: [PATCH] ucc_geth_ethtool: Fix a few HW stats counters.
> > > 
> > > Noticed that ethtool -S didn't display tx-xxx-frames correctly.
> > > Fix it and a few others while I am there. Strangely, the 
> > > rx-jumbo-frames counter still counts pkgs even though I 
> think there 
> > > isn't any packtes above 1518.
> > > 
> > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> > > ---
> > > 
> > > Havn't seen this go in or ACK/NACK. Resending.
> > > 
> > >  drivers/net/ucc_geth_ethtool.c |    3 +--
> > >  1 files changed, 1 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/net/ucc_geth_ethtool.c 
> > > b/drivers/net/ucc_geth_ethtool.c index a995a3a..0eddf50 100644
> > > --- a/drivers/net/ucc_geth_ethtool.c
> > > +++ b/drivers/net/ucc_geth_ethtool.c
> > > @@ -60,7 +60,6 @@ static char 
> hw_stat_gstrings[][ETH_GSTRING_LEN] = {
> > >  	"rx-broadcast-frames",
> > >  	"stats-counter-carry",
> > >  	"stats-counter-mask",
> > > -	"rx-dropped-frames",
> > >  };
> > >  
> > >  static char tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = { @@
> > > -73,6 +72,7 @@ static char 
> tx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
> > >  	"tx-frames-ok",
> > >  	"tx-excessive-differ-frames",
> > >  	"tx-256-511-frames",
> > > +	"tx-512-1023-frames",
> > >  	"tx-1024-1518-frames",
> > >  	"tx-jumbo-frames",
> > >  };
> > > @@ -101,7 +101,6 @@ static char
> > > rx_fw_stat_gstrings[][ETH_GSTRING_LEN] = {
> > >  	"rx-vlan-removed",
> > >  	"rx-vlan-replaced",
> > >  	"rx-vlan-inserted",
> > > -	"rx-ip-checksum-errors",
> > >  };
> > >  
> > >  #define UEC_HW_STATS_LEN ARRAY_SIZE(hw_stat_gstrings)
> > > --
> > > 1.5.5.1
> > > 
> > > 
> > 
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html