netdev - Re: SFC driver implements its own I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.62.0805151551330.13626@dolphin.home>
Date:	Thu, 15 May 2008 15:52:42 +0100 (BST)
From:	Michael Brown <mbrown@...systems.co.uk>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Jeff Garzik <jgarzik@...hat.com>, netdev@...r.kernel.org,
	Linux I2C <i2c@...sensors.org>,
	linux-net-drivers@...arflare.com
Subject: Re: SFC driver implements its own I2C support

On Thu, 15 May 2008, Jean Delvare wrote:
> > I think there may also have been issues with the fact that the i2c 
> > system allows for failures on the shutdown path (e.g. 
> > i2c_detach_client() can return a failure), which becomes awkward to 
> > handle when you are in the middle of a shutdown path that is not 
> > allowed to fail (e.g. a pci_driver->remove method).
> 
> This part of the code has been reworked completely. That being said, I 
> see that the i2c_driver remove method returns an int not void, so it can 
> still fail. There doesn't seem to be a common behavior in this respect 
> amongst subsystems, some allow the remove method to fail and others 
> don't. If you think that the i2c subsystem should not let remove methods 
> fail, we can discuss this. But most likely, the error code is purely 
> informative so it doesn't really matter if we return it or void.

It does matter if the i2c remove failure indicates that data structures 
are still left linked in to various lists etc.

Michael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html