netdev - Re: [PATCH net-next 3/6] [BNX2]: Remove the rx_offset field from the bnx2 structure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1210975629.5938.12.camel@dell>
Date:	Fri, 16 May 2008 15:07:09 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
cc:	"David Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, andy@...yhouse.net,
	benli@...adcom.com
Subject: Re: [PATCH net-next 3/6] [BNX2]: Remove the rx_offset field
 from the bnx2 structure.

On Fri, 2008-05-16 at 21:29 +0100, Ben Hutchings wrote:
> > +#define BNX2_RX_OFFSET               sizeof(struct l2_fhdr) + 2
> 
> The definition needs parentheses around it.  You would get away this
> except for this one place where BNX2_RX_OFFSET is subtracted.

Good point.  The bug would cause the jumbo threshold to be off by 2.  
It would not make much difference in this particular case.

Thanks for spotting this and I'll generate a new patch.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html