netdev - Re: [PATCH -next] 3c515: fix using pnp_get_resource when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805161258.04265.bjorn.helgaas@hp.com>
Date:	Fri, 16 May 2008 12:58:03 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	netdev <netdev@...r.kernel.org>, jgarzik <jgarzik@...ox.com>,
	linux-next@...r.kernel.org, akpm <akpm@...ux-foundation.org>,
	Adam M Belay <abelay@....edu>, Adam Belay <ambx1@....rr.com>
Subject: Re: [PATCH -next] 3c515: fix using pnp_get_resource when CONFIG_ISAPNP=n

On Friday 16 May 2008 12:21:35 pm Randy Dunlap wrote:
> Bjorn Helgaas wrote:
> > I prefer CONFIG_PNP to __ISAPNP__ in general, but I see
> > you're just following the other tests in the same file.
> 
> Yes.  And it would need to be CONFIG_ISAPNP, not CONFIG_PNP.

Huh.  Sure enough.  I hadn't even noticed pnp_find_dev().
I'm not sure why pnp_find_dev() should be under CONFIG_ISAPNP
rather than CONFIG_PNP, other than the fact that it uses
ISAPNP_ANY_ID.

On the other hand, there are only 25-30 users of pnp_find_dev();
maybe I should just look at converting them and nuking the
compat interfaces completely.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html