netdev - Re: [Bonding-devel] [patch] bondig - arp_interval with low value => Oops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5888.1211081960@death>
Date:	Sat, 17 May 2008 20:39:20 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Joe Eykholt <jre@...vasystems.com>
cc:	Nicolas 2P <nicolas.2p.debian@...e.fr>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, bonding-devel@...ts.sourceforge.net,
	linux-net@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [Bonding-devel] [patch] bondig - arp_interval with low value => Oops. 

Joe Eykholt <jre@...vasystems.com> wrote:

>Nicolas 2P wrote:
[...]
>> @@ -2837,7 +2837,7 @@
>> 
>>         read_lock(&bond->lock);
>> 
>> -       delta_in_ticks = (bond->params.arp_interval * HZ) / 1000;
>> +       delta_in_ticks = msecs_to_jiffies(bond->params.arp_interval * HZ);
>
>This seems like it should be just:
>
>	delta_in_ticks = msecs_to_jiffies(bond->params.arp_interval);

	Yes.  I've corrected this already in my copy (which I'll be
posting momentarily).

>Same for the other changes?

	The other two instances were correct, only the last change had
the extra "* HZ".

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html