netdev - Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2008 11:27:50 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Steve Glendinning" <steve.glendinning@...c.com>
Cc:	Michael.Hennerich@...log.com,
	"Bill Gatliff" <bgat@...lgatliff.com>, netdev@...r.kernel.org,
	ian.saturley@...c.com, "Bahadir Balban" <Bahadir.Balban@....com>,
	"Dustin Mcintire" <dustin@...soria.com>, catalin.marinas@....com,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver

On Mon, May 19, 2008 at 8:34 AM, Steve Glendinning
<steve.glendinning@...c.com> wrote:
> +++ b/drivers/net/smsc911x.c
> + * History:
> + *   05/05/2005 bahadir.balban@....com
> + *     - Transition to linux coding style
> + *     - Platform driver and module interface

i thought we were against this sort of changelog stuff in files.  let
the scm take care of the changelog.

> +static int smsc911x_init(struct net_device *dev)
> +static int smsc911x_drv_probe(struct platform_device *pdev)

missing __devinit

> +static int smsc911x_drv_remove(struct platform_device *pdev)

missing __devexit

> +static struct platform_driver smsc911x_driver = {
> +       .probe = smsc911x_drv_probe,
> +       .remove = smsc911x_drv_remove,
> +       .driver = {
> +               .name = SMSC_CHIPNAME,
> +       },
> +};

no suspend/resume ? :/
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html