netdev - Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1211214246.24946.47.camel@pc1117.cambridge.arm.com>
Date:	Mon, 19 May 2008 17:24:06 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Steve Glendinning <steve.glendinning@...c.com>
Cc:	Michael.Hennerich@...log.com, Enrik.Berkhan@...com,
	hennerich@...ckfin.uclinux.org, ian.saturley@...c.com,
	uclinux-dist-devel@...ckfin.uclinux.org, netdev@...r.kernel.org,
	Bahadir Balban <Bahadir.Balban@....com>,
	Dustin Mcintire <dustin@...soria.com>,
	Bill Gatliff <bgat@...lgatliff.com>
Subject: Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

On Mon, 2008-05-19 at 13:34 +0100, Steve Glendinning wrote:
> Attached is a driver for SMSC's LAN911x and LAN921x families of embedded
> ethernet controllers.
[...]
>  drivers/net/Kconfig    |   13 +
>  drivers/net/Makefile   |    1 +
>  drivers/net/smsc911x.c | 2285 ++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/smsc911x.h |  389 ++++++++

Maybe you should patch the MAINTAINERS file as well since it's not clear
from the file header who is maintaining it.

> --- /dev/null
> +++ b/drivers/net/smsc911x.h
[...]
> +/* platform_device configuration data, should be assigned to
> + * the platform_device's dev.platform_data */
> +struct smsc911x_platform_config {
> +	unsigned int irq_polarity;
> +	unsigned int irq_type;
> +};

BTW, how could this structure be used in the platform specific code
(arch/arm/mach-*/* in my case)? This header file cannot be included
since it is not under the include/ directory and redefining the
structure for each platform is prone to errors (and too much
duplication). I can see other drivers place a header file (maybe only
containing the structure definition) in include/linux/ or include/asm-*/
(the latter if it is specific to only one architecture which I don't
think it is the case here). 

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html