netdev - Re: Question about VLAN + checksum offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4831BCB4.9070704@trash.net>
Date:	Mon, 19 May 2008 19:45:24 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
CC:	Ichiro Suzuki <isuzuki@...aclelinux.com>, netdev@...r.kernel.org,
	Naohiro Ooiwa <nooiwa@...aclelinux.com>
Subject: Re: Question about VLAN + checksum offloading

Patrick McHardy wrote:
> Waskiewicz Jr, Peter P wrote:
>>> o If so, is there any mechanism to propagate  real_dev->features 
>>> flags in vlan.c?
>>
>> There isn't an explicit way.  I had written patches into e1000, igb,
>> e1000e, and ixgbe to propogate the VLAN flags within the driver when the
>> VLAN device was created.  The trick though is if you remove a feature
>> flag with ethtool, say checksum offload, on your main device, you
>> probably should turn it off on your VLAN devices.  Patrick McHardy
>> pointed me at netdev_feature_change() to use within the driver.  I'll
>> admit I haven't had the time to fix my drivers to use this call, but it
>> certainly looks like the way to go.  Please see the (middle) of the
>> thread here: http://marc.info/?l=linux-netdev&m=120878809806631&w=2
>>
>>> o If such mechanism doesn't exist, is my patch reasonable?
>>
>> I would say yes, halfway.  The issue is you probably want to remove the
>> feature flag from the VLAN device if you removed the flag from the
>> parent device as well.
> 
> 
> Yes, it should use the same mechanism as suggested for the
> VLAN accel feature. And it should be limited to features

I meant TSO, sorry.

> that are known to work, not just blindly copy everything.
> 
> I will be catching up with the VLAN patches posted recently
> sometime next week. I guess I can then also add a patch for
> feature propagation myself if you don't beat me to it :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html