netdev - Re: [PATCH] net/ipv4/arp.c: Use the exported hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080520.154551.54365414.davem@davemloft.net>
Date:	Tue, 20 May 2008 15:45:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	crquan@...il.com, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from
 lib/hexdump.c instead

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Tue, 20 May 2008 15:40:12 -0700

> On Tue, 2008-05-20 at 15:36 -0700, David Miller wrote:
> > From: Denis Cheng <crquan@...il.com>
> > Date: Mon, 19 May 2008 02:37:44 +0800
> > 
> > > Here the local hexbuf is a duplicate of global const char hex_asc from
> > > lib/hexdump.c, except the hex letters' cases:
> > > 
> > > const char hexbuf[] = "0123456789ABCDEF";
> > > 
> > > const char hex_asc[] = "0123456789abcdef";
> > > 
> > > and here to print HW addresses, the hex cases are not significant.
> > > 
> > > Signed-off-by: Denis Cheng <crquan@...il.com>
> > 
> > Applied, thanks.
> 
> You may want to use the hex_asc_hi, hex_asc_lo helpers to do the
> mask/shifts for you.

Good idea, I'll revert, Denis can you generate a new patch?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html