netdev - Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080520144822.GR28241@solarflare.com>
Date:	Tue, 20 May 2008 15:48:23 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Peter Warasin <peter@...ian.com>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

Patrick McHardy wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index b11e6e1..3be4559 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -514,10 +514,11 @@ struct net_device
>  #define NETIF_F_NETNS_LOCAL	8192	/* Does not change network namespaces */
>  #define NETIF_F_MULTI_QUEUE	16384	/* Has multiple TX/RX queues */
>  #define NETIF_F_LRO		32768	/* large receive offload */
> +#define NETIF_F_VLAN_TSO	65536	/* Supports TSO for VLANs */
> 
>  	/* Segmentation offload features */
> -#define NETIF_F_GSO_SHIFT	16
> -#define NETIF_F_GSO_MASK	0xffff0000
> +#define NETIF_F_GSO_SHIFT	20
> +#define NETIF_F_GSO_MASK	0xfff00000

I really don't think it's a good idea to move around existing flags.  How
about stealing some of the unused high-order bits of NETIF_F_GSO_MASK
instead?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html