netdev - Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4832FBF5.1000305@trash.net>
Date:	Tue, 20 May 2008 18:27:33 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	Ben Greear <greearb@...delatech.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

Ben Hutchings wrote:
> Ben Greear wrote:
>> Patrick McHardy wrote:
>>> Ben Hutchings wrote:
>>>> I really don't think it's a good idea to move around existing flags.  
>>>> How
>>>> about stealing some of the unused high-order bits of NETIF_F_GSO_MASK
>>>> instead?
>>>
>>> Mhh it doesn't really belong there. Whats the problem with
>>> moving these bits? They are only used internally (and use
>>> up too much space anyway).
>> I've been running with it shifted to 24 on 2.6.25 with no problems.   If 
>> no one else objects, I'd prefer it shifted all the way
>> to 24 to make room for more flags w/out additional changes in the 
>> shiftage later...
> 
> I would certainly be happy to see NETIF_F_GSO_MASK narrowed.  It's just a
> question of whether the low-order or high-order bits are removed.  My
> instinct is not to change the existing assigned flags if it's not really
> necessary.  They are exposed through /sys/class/net/ even if the flag
> names aren't part of the user-land headers.


I don't really care which bits exactly are used, so sure, I'll
update it before sending a final patch. But frankly, these bits
shouldn't have been exported through sysfs in the first place.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html