netdev - Re: [ofa-general] Re: [PATCH 10/13] QLogic VNIC: Driver Statistics collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71d336490805200952k2c31b6abkfcf70ed7481a95d@mail.gmail.com>
Date:	Tue, 20 May 2008 22:22:50 +0530
From:	"Ramachandra K" <ramachandra.kuchimanchi@...gic.com>
To:	"Roland Dreier" <rdreier@...co.com>
Cc:	netdev@...r.kernel.org, poornima.kamath@...gic.com,
	general@...ts.openfabrics.org, amar.mudrankit@...gic.com
Subject: Re: [ofa-general] Re: [PATCH 10/13] QLogic VNIC: Driver Statistics collection

Roland,

On Fri, May 16, 2008 at 4:03 AM, Roland Dreier <rdreier@...co.com> wrote:
>  > +#else       /*CONFIG_INIFINIBAND_VNIC_STATS*/
>  > +
>  > +static inline void vnic_connected_stats(struct vnic *vnic)
>  > +{
>  > +    ;
>  > +}
>
> there are an awful lot of stubs here.  Do you really expect anyone to
> set CONFIG_INFINIBAND_QLGC_VNIC_STATS=n?

Sorry, missed this comment from the first round of review. Yes, the default
behavior we want is to disable the statistics collection as some of the
statistics collection is in the data transfer path and hence this code
can add overheads. These statistics are more for performance debugging/tuning.

Regards,
Ram
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html