netdev - Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 May 2008 20:31:48 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

Ben Hutchings wrote:
> Patrick McHardy wrote:
>> +	if (dev->features & NETIF_F_VLAN_TSO)
>> +		vlandev->features |= dev->features &
>> +				     (NETIF_F_TSO | NETIF_F_TSO6);
>>     
>
> Shouldn't this mask the flags out of vlandev->features first?
>   
Yes, thanks.
>> +	dev->features = real_dev->features & (NETIF_F_TSO | NETIF_F_TSO6);
>>     
> This should also test the NETIF_F_VLAN_TSO flag and should copy the
> NETIF_F_ALL_CSUM and NETIF_F_SG flags since TSO requires those (see
> register_netdevice() feature fix-up).  Peter pointed out that TX checksum
> offload for VLANs might be available even without TSO; the same goes for
> scatter-gather but I don't know whether it's worth adding a flag for that.
>   

Thanks, I added NETIF_F_SG to the VLAN TSO flags and added a
NETIF_F_VLAN_CSUM flag for TX checksums. I didn't change
GSO_SHIFT so far.



View attachment "x" of type "text/plain" (3897 bytes)