netdev - Re: [PATCH] Fix frag list handling in TCP splice receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805211105.03947.opurdila@ixiacom.com>
Date:	Wed, 21 May 2008 11:05:03 +0300
From:	Octavian Purdila <opurdila@...acom.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix frag list handling in TCP splice receive

On Saturday 17 May 2008, Octavian Purdila wrote:
> If an skb does not have fragments but its fragment list is not empty (can
> happen, via LRO at least) and a previous tcp_read_sock has consumed
> the linear part of the skb then __skb_splice_bits:
>
> (a) incorrectly reports an error and
>
> (b) forgets to update the offset to account for the linear part
>
> Any of the two problems will cause the subsequent __skb_splice_bits call
> (the one that handles the fragment list skbs) to either skip data, or, if
> the unadjusted offset is greater then the size of the next skb, make
> tcp_splice_read loop forever.
>

Hi,

Any comments, please?

Patch for 2.6.25 is here:

http://www.spinics.net/lists/netdev/msg63541.html

Thanks,
tavi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html