netdev - Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48344DAA.4060107@trash.net>
Date:	Wed, 21 May 2008 18:28:26 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices

Herbert Xu wrote:
> Patrick McHardy <kaber@...sh.net> wrote:
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index b11e6e1..3be4559 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -514,10 +514,11 @@ struct net_device
>> #define NETIF_F_NETNS_LOCAL    8192    /* Does not change network namespaces */
>> #define NETIF_F_MULTI_QUEUE    16384   /* Has multiple TX/RX queues */
>> #define NETIF_F_LRO            32768   /* large receive offload */
>> +#define NETIF_F_VLAN_TSO       65536   /* Supports TSO for VLANs */
> 
> This has the potential to get pretty messy.  How about making a
> driver call back that the VLAN layer can invoke to get the supported
> feature bits for the VLAN device?
> 
> You have to modify the driver to set the bit anyway so could as well
> add a function instead of a bit.


I thought about this myself, my second idea was to add a
mask for feature bits to be propagated. Unless there is a
need for the driver to determine them at runtime, thats
slightly simpler. The driver would do:

dev->vlan_features = NETIF_F_CSUM_ALL | ...

What do you think about this?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html