netdev - Re: [PATCH] netfilter: conntrack_helper needs to include rculist.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080521.144550.151762863.davem@davemloft.net>
Date:	Wed, 21 May 2008 14:45:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	randy.dunlap@...cle.com
Cc:	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] netfilter: conntrack_helper needs to include rculist.h

From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Wed, 21 May 2008 14:21:39 -0700

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> nf_conntrack_helper users rcu hlist functions so it needs to #include
> rculist.h.
> 
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu'
> filter/nf_conntrack_helper.o] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

This needs to go in via whatever tree adds the linux/rculist.h header file,
which isn't net-next-2.6 as far as I can tell. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html