lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 21 May 2008 18:55:30 -0700
From:	Divy Le Ray <divy@...lsio.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, swise@...ngridcomputing.com
Subject: Re: [PATCH 2/3 2.6.27] cxgb3 - Add page support to jumbo frame Rx
 queue

Andrew Morton wrote:
> On Tue, 20 May 2008 18:57:37 -0700
> Divy Le Ray <divy@...lsio.com> wrote:
>
>   
>> From: Divy Le Ray <divy@...lsio.com>
>>
>> Add page support to Jumbo frame Rx queues.
>>
>> ...
>>
>> @@ -460,7 +464,8 @@ nomem:				q->alloc_failed++;
>>  			if (q->use_pages) {
>>  				if (q->pg_chunk.page) {
>>  					put_page(q->pg_chunk.page);
>> -					__free_page(q->pg_chunk.page);
>> +					__free_pages(q->pg_chunk.page,
>> +						     q->order);
>>  					q->pg_chunk.page =
>>  						sd->pg_chunk.page = NULL;
>>  				}
>>     
>
> This hunk doesn't apply to 2.6.26-rc3, afacit.  The code it's patching
> just isn't there.  But I think I fixed it up OK.
>   

My bad.
I modified the first patch just before submission - namely to avoid 
freeing the Rx page if the DMA mapping failed.
I managed to submit without locally pushing the follwing patches first. 
Sorry about that.
I'm resubmitting the series.

Cheers,
Divy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists