lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <48352F80.6010708@openvz.org>
Date:	Thu, 22 May 2008 12:32:00 +0400
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: build failure from ip6mr stats change.

David Miller wrote:
> How could you possibly have test compiled this?
> 
> You kept the "stats->foo" dereferences but those all
> need to be "stats.foo"

Yikes! 8( I swear I saw the

  CC    net/ipv6/ip6mr.o

line when building one...

Argh :( I didn't turn the CONFIG_IP_PIMSM on and all statistics
happened to be under this option only.

> I've fixed it up as below.
> 
> UGH, the ipv4 ipmr patch has the same problem, I'll fix that up to :-(

Thank you. Sorry for bad patchset :(

> ip6mr: Use on-device stats instead of private ones.
> 
> Similar to ipmr.
> 
> [ Fix build failures -DaveM ]
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
> Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ