netdev - Re: [PATCH] RXRPC: Use skb_queue_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9913.1211465456@redhat.com>
Date:	Thu, 22 May 2008 15:10:56 +0100
From:	David Howells <dhowells@...hat.com>
To:	Wang Chen <wangchen@...fujitsu.com>
Cc:	dhowells@...hat.com, linux-afs@...ts.infradead.org,
	NETDEV <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] RXRPC: Use skb_queue_walk_safe()

Wang Chen <wangchen@...fujitsu.com> wrote:

> Because the list could be modified inside the loop, use
> skb_queue_walk_safe().

This is unnecessary.  If skb_insert() is called in the loop, the very next
line is a goto that exits the loop immediately.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html