netdev - Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2008 16:52:36 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Konrad Rzeszutek <konrad@...tualiron.com>
Cc:	open-iscsi@...glegroups.com, davem@...emloft.net,
	michaelc@...wisc.edu, anilgv@...adcom.com, netdev@...r.kernel.org,
	linux-scsi@...r.kernel.org, Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

Konrad Rzeszutek wrote:
> > + * bnx2i_iscsi_license_error - displays iscsi license related error message
> 
> Doesn't look very license related. Just says 'not supported'.

Could be that some hardware strap pin is being used as a dongle.  This
doesn't seem entirely in the spirit of GPL, and would be rather easy to
remove...

> > + * @hba:		adapter instance pointer
> > + * @error_code:		error classification
> > + *
> > + * Puts out an error log when driver is unable to offload iscsi connection
> > + *	due to license restrictions
> 
> Maybe adding in some extra information to the error, such as: "Due to
> GPL restrictions, etc.." .. What does 'LOM' stand for?

LOM is a common abbreviation for "LAN on motherboard" as opposed to an
expansion card.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html