netdev - Re: [PATCH 1/2] VIRTIO: Use __skb_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2008 14:01:20 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Wang Chen <wangchen@...fujitsu.com>
CC:	Rusty Russell <rusty@...tcorp.com.au>,
	"David S. Miller" <davem@...emloft.net>,
	NETDEV <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2] VIRTIO: Use __skb_queue_purge()

Wang Chen wrote:
> Use standard routine for queue purging.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> ---
>  drivers/net/virtio_net.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index f926b5a..fe7cdf2 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -470,8 +470,7 @@ static void virtnet_remove(struct virtio_device *vdev)
>  		kfree_skb(skb);
>  		vi->num--;
>  	}
> -	while ((skb = __skb_dequeue(&vi->send)) != NULL)
> -		kfree_skb(skb);
> +	__skb_queue_purge(&vi->send);
>  

applied 1-2


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html