lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 May 2008 20:03:02 +0200 From: Patrick McHardy <kaber@...sh.net> To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> CC: Herbert Xu <herbert@...dor.apana.org.au>, davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices Waskiewicz Jr, Peter P wrote: >>> I thought about this myself, my second idea was to add a mask for >>> feature bits to be propagated. Unless there is a need for >>> >> the driver >> >>> to determine them at runtime, thats slightly simpler. The >>> >> driver would >> >>> do: >>> >>> dev->vlan_features = NETIF_F_CSUM_ALL | ... >>> >>> What do you think about this? >>> >> Yes that sounds great! >> > > The issue is how does the driver know how to pull those flags off the > VLAN device when the parent has TSO or CSUM offload disabled? The only > way I could come up with it was in my original patch in the drivers to > loop through the entire VLAN group array, and clear the flag on existing > devices. > Yes, thats also what my patch is doing. Not a big deal I guess, we're doing that for all kinds of notifications already and nobody ever complained. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists