netdev - RE: [VLAN]: Use bitmask of feature flags instead of seperate feature bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 May 2008 00:17:02 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"Herbert Xu" <herbert@...dor.apana.org.au>,
	"Patrick McHardy" <kaber@...sh.net>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"Linux Netdev List" <netdev@...r.kernel.org>
Subject: RE: [VLAN]: Use bitmask of feature flags instead of seperate feature bits

> On Fri, May 23, 2008 at 09:02:39AM +0200, Patrick McHardy wrote:
> > 
> >     [VLAN]: Use bitmask of feature flags instead of 
> seperate feature 
> > bits
> >     
> >     Herbert Xu points out that the use of seperate feature 
> bits for features
> >     to be propagated to VLAN devices is going to get messy 
> real soon.
> >     Replace the VLAN feature bits by a bitmask of feature 
> flags to be
> >     propagated and restore the old GSO_SHIFT/MASK values.
> >     
> >     Signed-off-by: Patrick McHardy <kaber@...sh.net>
> 
> Looks great Patrick, thanks!
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> 
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Agreed.  It looks great, and I'll also test it on ixgbe tomorrow
morning.

Cheers,

-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html