netdev - DECLARE_PCI_UNMAP_{ADDR,LEN} question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 25 May 2008 07:48:38 +0300
From:	Marin Mitov <mitov@...p.bas.bg>
To:	linux-kernel@...r.kernel.org
Cc:	netdev@...r.kernel.org
Subject: DECLARE_PCI_UNMAP_{ADDR,LEN} question

Hi all,

In Documentation/DMA-mapping.txt is written:

NOTE: DO NOT put a semicolon at the end of the 
DECLARE_PCI_UNMAP_{ADDR,LEN}() macro.

While the output of 
grep DECLARE_PCI_UNMAP_  drivers/net/* 
contains lines with and without semicolon:
drivers/net/acenic.h:   DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/acenic.h:   DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/acenic.h:   DECLARE_PCI_UNMAP_LEN(maplen)
drivers/net/bnx2.h:     DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/bnx2.h:     DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/bnx2x.h:    DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/qla3xxx.h:   DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/qla3xxx.h:   DECLARE_PCI_UNMAP_LEN(maplen);
drivers/net/qla3xxx.h:   DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/qla3xxx.h:   DECLARE_PCI_UNMAP_LEN(maplen);
drivers/net/skge.h:     DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/skge.h:     DECLARE_PCI_UNMAP_LEN(maplen);
drivers/net/sky2.h:     DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/sky2.h:     DECLARE_PCI_UNMAP_ADDR(maplen);
drivers/net/sky2.h:     DECLARE_PCI_UNMAP_ADDR(data_size);
drivers/net/tg3.h:      DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/tg3.h:      DECLARE_PCI_UNMAP_ADDR(mapping)

My question is: 
Why one should NOT put semicolon at the end of the macro?
If it is _really_ important, should it be removed/patched?

Thank you for your answers.

Regards

Marin Mitov

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html