netdev - Re: [PATCH 2.6.26-rc4] fix double call of kfree_skb in net/llc/llc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84ee89da0805270100s3e0da6dbh7dd8f3744b2a6c8f@mail.gmail.com>
Date:	Tue, 27 May 2008 14:00:08 +0600
From:	"Dmitry Petukhov" <dmgenp@...il.com>
To:	"Wei Yongjun" <yjwei@...fujitsu.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	acme@...stprotocols.net
Subject: Re: [PATCH 2.6.26-rc4] fix double call of kfree_skb in net/llc/llc_sap.c

2008/5/27 Wei Yongjun <yjwei@...fujitsu.com>:
> Not correct, since kfree_skb(skb) is used after skb_get(skb).
>
> First, it used skb_get inc the users counter, and then, kfree_skb will dec
> the users count, not do the real free.

The problem is what there will be one extra call to kfree_skb without
this return, and it will decrease the counter one extra time then.

//sorry for re-post, forgot to CC the list
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html