netdev - Re: [PATCH 2/7] [CCID-2]: Remove ccid2hc{tx,rx}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080527.062536.64095383.davem@davemloft.net>
Date:	Tue, 27 May 2008 06:25:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/7] [CCID-2]: Remove ccid2hc{tx,rx}_ prefixes

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Tue, 27 May 2008 09:32:42 +0100

> This patch fixes two problems caused by the ubiquitous long "hctx->ccid2htx_"
> and "hcrx->ccid2hcrx_" prefixes:
>  * code becomes hard to read;
>  * multiple-line statements are almost inevitable even for simple expressions;
> The prefixes are not really necessary (compare with "struct tcp_sock").
> 
> There had been previous discussion of this on dccp@...r, but so far this was
> not followed up (most people agreed that the prefixes are too long).
> 
> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>
> Signed-off-by: Leandro Melo de Sales <leandroal@...il.com>

You're the dccp maintainer, but...

The whole reason we use these member prefixes is so that the
tree is actually greppable.  tcp_sock is the way it is because
we never enforced this useful policy back when it was originally
created.

If you use short member names, it becomes eventually impossible
to grep for "->foo" and have it not match a ton of crap you
are completely not interested in.  Using a prefix creates a
struct member namespace, and thus fixes that problem.

Use editor macros if you don't want to type so much :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html