netdev - Re: race in skb_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805271739.11612.opurdila@ixiacom.com>
Date:	Tue, 27 May 2008 17:39:11 +0300
From:	Octavian Purdila <opurdila@...acom.com>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: race in skb_splice_bits?

On Tuesday 27 May 2008, Evgeniy Polyakov wrote:
> On Tue, May 27, 2008 at 05:21:48PM +0400, Evgeniy Polyakov 
(johnpol@....mipt.ru) wrote:
> > On Tue, May 27, 2008 at 03:53:49PM +0300, Octavian Purdila 
(opurdila@...acom.com) wrote:
> > > When you interrupt the program, the system will crash.
> >
> > Cool!
> >
> > I've reproduced the problem and will try to work it out, thank you.
>
> Attached patch fixes the crash for me, Octavian could you please test
> it.
>

On my system it still crashes, if I interrupt the program before splice 
blocks:

[   16.170009] NIP [8014d0c0] tcp_read_sock+0x138/0x1f8
[   16.170009] LR [8014d090] tcp_read_sock+0x108/0x1f8
[   16.170009] Call Trace:
[   16.170009] [bcd21dd0] [8014d090] tcp_read_sock+0x108/0x1f8 (unreliable)
[   16.170009] [bcd21e20] [8014b590] __tcp_splice_read+0x34/0x44
[   16.170009] [bcd21e40] [8014b620] tcp_splice_read+0x80/0x220
[   16.170009] [bcd21e90] [80105730] sock_splice_read+0x2c/0x44
[   16.170009] [bcd21ea0] [8008a374] do_splice_to+0x90/0xac
[   16.170009] [bcd21ed0] [8008a850] do_splice+0x258/0x2f0
[   16.170009] [bcd21f10] [8008b1d4] sys_splice+0xe0/0xe8
[   16.170009] [bcd21f40] [8000ff14] ret_from_syscall+0x0/0x38


Thanks,
tavi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html