netdev - Re: race in skb_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080527152234.GA16419@2ka.mipt.ru>
Date:	Tue, 27 May 2008 19:22:34 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Octavian Purdila <opurdila@...acom.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: race in skb_splice_bits?

On Tue, May 27, 2008 at 07:12:59PM +0400, Evgeniy Polyakov (johnpol@....mipt.ru) wrote:
> On Tue, May 27, 2008 at 07:09:31PM +0400, Evgeniy Polyakov (johnpol@....mipt.ru) wrote:
> > Please test this one assuming there are no other patches applied before.
> 
> A typo sneaked into the patch, please try this one.

The same wrong one, sorry about that.

Idea is to hold skb between release/lock sock calls and thus do not
allow to free it by core stack when it is being released. Patch still
misses the case, when socket is released and skb was dequeued, so splice
will try to dequeue it again, which will crash. I will think on how to
fix the issue.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html