netdev - Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <396556a20805301211g7dd98ae7m185a356e611e81aa@mail.gmail.com>
Date:	Fri, 30 May 2008 12:11:44 -0700
From:	"Adam Langley" <agl@...erialviolet.org>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled

On Fri, May 30, 2008 at 12:02 PM, Ben Hutchings
<bhutchings@...arflare.com> wrote:
> Putting an #ifdef..#endif in the middle of an if () is a bit nasty.  Why not
> define md5 and set it to 0 if CONFIG_TCP_MD5SIG is not set?  The compiler
> should be able to optimise it away if it's always initialised to 0.

That's a good point, thanks. Followup patch in a second...



AGL

-- 
Adam Langley agl@...erialviolet.org http://www.imperialviolet.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html