netdev - Re: [PATCH 16/37] net/usb: use get/put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080531024336.gszdaepdog8woow0@hayate.ip6>
Date:	Sat, 31 May 2008 02:43:36 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	dbrownell@...rs.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Garzik <jeff@...zik.org>,
	David Miller <davem@...emloft.net>,
	linux-netdev <netdev@...r.kernel.org>,
	linux-arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH 16/37] net/usb: use get/put_endian helpers

Quoting Harvey Harrison <harvey.harrison@...il.com>:

> diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
> index ae467f1..bda89c9 100644
> --- a/drivers/net/usb/rndis_host.c
> +++ b/drivers/net/usb/rndis_host.c
> @@ -407,7 +407,7 @@ generic_rndis_bind(struct usbnet *dev, struct   
> usb_interface *intf, int flags)
>  	u.set->oid = OID_GEN_CURRENT_PACKET_FILTER;
>  	u.set->len = ccpu2(4);
>  	u.set->offset = ccpu2((sizeof *u.set) - 8);
> -	*(__le32 *)(u.buf + sizeof *u.set) = RNDIS_DEFAULT_FILTER;
> +	put_le32(RNDIS_DEFAULT_FILTER, (__le32 *)(u.buf + sizeof(*u.set)));
>
>  	retval = rndis_command(dev, u.header);
>  	if (unlikely(retval < 0)) {

RNDIS_DEFAULT_FILTER already is le32, put_le32 breaks it.

  - Jussi



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html