lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 30 May 2008 22:12:52 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Cesar Eduardo Barros <cesarb@...arb.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] sc92031: remove bogus unlikely()

Cesar Eduardo Barros wrote:
> Commit 5a0a92e67b5009a71e011658da04fb92dad8961f mentions len < ETH_ZLEN
> is true for ARP packets. This obviously is not unlikely.
> 
> Signed-off-by: Cesar Eduardo Barros <cesarb@...arb.net>
> ---
>  drivers/net/sc92031.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
> index b4b6380..61955f8 100644
> --- a/drivers/net/sc92031.c
> +++ b/drivers/net/sc92031.c
> @@ -972,7 +972,7 @@ static int sc92031_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  	skb_copy_and_csum_dev(skb, priv->tx_bufs + entry * TX_BUF_SIZE);
>  
>  	len = skb->len;
> -	if (unlikely(len < ETH_ZLEN)) {
> +	if (len < ETH_ZLEN) {
>  		memset(priv->tx_bufs + entry * TX_BUF_SIZE + len,

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists