netdev - Re: [PATCH -next] cxgb3: fix build error when INET=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4840B5C5.2010206@pobox.com>
Date:	Fri, 30 May 2008 22:19:49 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	netdev <netdev@...r.kernel.org>, divy@...lsio.com,
	linux-next@...r.kernel.org, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] cxgb3: fix build error when INET=n

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> cxgb3 uses lro_* functions and selects INET_LRO, but this doesn't help unless
> INET is already enabled, so make the driver depend on INET also.
> 
> sge.c:(.text+0x9f09a): undefined reference to `lro_flush_all'
> sge.c:(.text+0x9f62f): undefined reference to `lro_receive_skb'
> sge.c:(.text+0x9f8a3): undefined reference to `lro_receive_frags'
> sge.c:(.text+0x9fbe0): undefined reference to `lro_vlan_hwaccel_receive_skb'
> sge.c:(.text+0x9ffcd): undefined reference to `lro_vlan_hwaccel_receive_frags'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/net/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20080530.orig/drivers/net/Kconfig
> +++ linux-next-20080530/drivers/net/Kconfig
> @@ -2407,7 +2407,7 @@ config CHELSIO_T1_NAPI
>  
>  config CHELSIO_T3
>  	tristate "Chelsio Communications T3 10Gb Ethernet support"
> -	depends on PCI
> +	depends on PCI && INET
>  	select FW_LOADER
>  	select INET_LRO
>  	help
> --

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html