netdev - Re: [PATCH 1/2] sfc: Use kernel I2C system and i2c-algo-bit driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 31 May 2008 17:07:40 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH 1/2] sfc: Use kernel I2C system and i2c-algo-bit driver

On Sat, 31 May 2008 12:27:02 +0100, Ben Hutchings wrote:
> Jean Delvare wrote:
> > > @@ -2459,6 +2475,18 @@ int falcon_probe_nic(struct efx_nic *efx)
> > >  	if (rc)
> > >  		goto fail5;
> > >  
> > > +	/* Initialise I2C adapter */
> > > + 	efx->i2c_adap.owner = THIS_MODULE;
> > > + 	efx->i2c_adap.class = I2C_CLASS_HWMON;
> > 
> > I doubt you want to do this. This would let any hardware monitoring
> > driver probe your bus for a device, while presumably you already know
> > which hardware monitoring device is present and you want to instantiate
> > the i2c client yourself. This will probably become clearer when you
> > start using the lm87 driver and modify it to support new-style i2c
> > binding.
>  
> So the class should be, what, 0?

Yes. Assuming a kzalloc'd structure, you can simply omit it.

> > > +	nic_data->i2c_data = falcon_i2c_bit_operations;
> > > +	nic_data->i2c_data.data = efx;
> > > + 	efx->i2c_adap.algo_data = &nic_data->i2c_data;
> > > +	efx->i2c_adap.dev.parent = &efx->pci_dev->dev;
> > > +	strcpy(efx->i2c_adap.name, "SFC4000 GPIO");
> > 
> > Please always use strlcpy.
>  
> OK.  I thought about it but it didn't seem worthwhile for a short constant
> string.

Until someone changes the string for a longer one (it's common to
include the I/O base) or the structure field is shortened to save some
memory... Always use strlcpy. In fact I'd like to see strcpy removed
from the kernel, it's almost always the wrong function to use.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html