netdev - Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080601223748.GI30769@solarflare.com>
Date:	Sun, 1 Jun 2008 23:37:49 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	eilong@...adcom.com, netdev <netdev@...r.kernel.org>,
	jeff@...zik.org, davem@...emloft.net,
	Eliezer Tamir <eliezert@...adcom.com>,
	Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH net-next 2/13]bnx2x: Adding bnx2x_link

Andi Kleen wrote:
[...]
> > +/* Programs an image to DSP's flash via the SPI port*/
> > +static u8 bnx2x_sfx7101_flash_download(struct bnx2x *bp, u8 port,
> > +				     u8 ext_phy_addr,
> > +				     char data[], u32 size)
> 
> Hmm does the driver really need a flash updater as standard
> functionality? That could be a separate program.
[...]

It shouldn't need to do this.  The boot loader in the SFX7101 allows
flash update through MDIO if the appropriate pin is pulled low at
reset (see phy_flash_cfg option in the sfc driver).  Of course that
doesn't help if the board doesn't allow this to be controlled...

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html