lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Jun 2008 01:48:19 +0900 (JST) From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> To: brian.haley@...com Cc: shanwei@...fujitsu.com, davem@...emloft.net, netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org Subject: Re: [PATCH v2] IPv6: fix bug when specifying the non-exist outgoing interface In article <20080603.014604.26891059.yoshfuji@...ux-ipv6.org> (at Tue, 03 Jun 2008 01:46:04 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> says: > In article <20080603.014105.73332390.yoshfuji@...ux-ipv6.org> (at Tue, 03 Jun 2008 01:41:05 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> says: > > > In article <48441C82.1070609@...com> (at Mon, 02 Jun 2008 12:14:58 -0400), Brian Haley <brian.haley@...com> says: > > > > > Shan Wei wrote: > > > > When specifying the outgoing interface with sendmsg, if the ipi6_addr is > > > > the unspecified address and the ipi6_ifindex is the not-exist interface, > > > > it should be fail and the errno should be set ENODEV. > > > > Actually, it does well(sendmsg returns on success ), because the kernel > > > > don't check the interface。 > > > > > > This patch changes this code path to be different than most others that > > > completely ignore the device for the unspecified address - for example > > > inet6_bind() and rawv6_bind(). Those paths only care about the device > > > for a link-local address, so I don't think this patch is correct. > > > > Semantics are different. sin6_scope_id is valid ifindex only if > > the scope is link-local (Note: scope-id is scope-specific; > > for example, for "site-local" addresses, the values cannot be > > directly mapped onto ifindex space). On the other hand, ipi6_ifindex > > is always effective even if the source address is global. > > 2 things: > - Check if ifindex is valid is always needed, anyway. > - Check for valid address ipv6_chk_addr() should not device-specific ~~~delete this > if the destination (or source) is link-local (or multicast, maybe). --yoshfuji -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists