netdev - Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iqwr662p.fsf@macbook.be.48ers.dk>
Date:	Mon, 02 Jun 2008 20:32:30 +0200
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Bill Gatliff <bgat@...lgatliff.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Steve Glendinning <steve.glendinning@...c.com>,
	netdev@...r.kernel.org, Michael.Hennerich@...log.com,
	Enrik.Berkhan@...com, hennerich@...ckfin.uclinux.org,
	ian.saturley@...c.com, uclinux-dist-devel@...ckfin.uclinux.org,
	catalin.marinas@....com, Bahadir Balban <Bahadir.Balban@....com>,
	Dustin Mcintire <dustin@...soria.com>
Subject: Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

>>>>> "Bill" == Bill Gatliff <bgat@...lgatliff.com> writes:

 >>> +	/* Initialise tx packet using broadcast destination address */
 >>> +	for (i = 0; i < 6; i++)
 >>> +		pdata->loopback_tx_pkt[i] = (char)0xFF;
 >> 
 >> The cast to char is just noise.

 Bill> Not sure.  What about signed vs. unsigned?

No, because char can be both signed and unsigned. The driver should
rather do a memset(pdate->loopback_tx_pkt, 0xff, ETH_ALEN);

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html