netdev - Re: [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Jun 2008 12:01:12 +0200
From:	Jens Gehrlein <sew_s@....de>
To:	Steve.Glendinning@...c.com
CC:	netdev@...r.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH 01/01] smsc911x: fix MAC addresssetting
 after reset

Hi Steve,

Steve.Glendinning@...c.com schrieb:
>> If the MAC address has been set externally (e. g. by the bootloader
>> or via command line), this setting is lost. This patch fixes the
>> problem by always setting the saved MAC address after soft reset.

Sorry. Newbie question:
How can I pass the MAC address via kernel command line for this driver? 
Is there a predefined parameter?
My problem is:
U-Boot resets the chip after each completed transfer. Wolfgang Denk 
suggested to pass the MAC address via kernel command line. I need the 
ethernet device at kernel startup to mount a root filesystem via NFS, so 
I added the platform device in my board specific code as shown below (it 
still relates to the old driver).
Should I patch the driver directly to get the MAC address via __setup()
or can I pass the MAC address via the device structures.

What do you suggest?

Thanks and best regards
Jens
-- 

static struct resource smc911x_resources[] = {
	[0] = {
		.start		= CS4_BASE_ADDR,
		.end		= CS4_BASE_ADDR + 0xFF,
		.flags		= IORESOURCE_MEM,
	},
	[1] = {
		.start		= MXC_GPIO_BASE + 4,
		.end		= MXC_GPIO_BASE + 4,
		.flags		= IORESOURCE_IRQ,
	},
};

static struct platform_device smc911x_device = {
	.name		= "smc911x",
	.id		= 0,
	.num_resources	= ARRAY_SIZE(smc911x_resources),
	.resource	= smc911x_resources,
};

static struct platform_device *myboard_devices[] __initdata = {
	&smc911x_device,
};

static int __init <myboard>_devices_setup(void)
{
	return platform_add_devices(myboard_devices, ARRAY_SIZE(myboard_devices));
}
device_initcall(myboard_devices_setup);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html